Skip to content

Commit

Permalink
[Refactor] use es-errors, get-proto, has-property-descriptors d…
Browse files Browse the repository at this point in the history
…irectly
  • Loading branch information
ljharb committed Jan 2, 2025
1 parent efd151b commit a9a3954
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 8 deletions.
2 changes: 1 addition & 1 deletion implementation.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var IsDetachedBuffer = require('es-abstract/2024/IsDetachedBuffer');
var setFunctionName = require('set-function-name');
var isSharedArrayBuffer = require('is-shared-array-buffer');

var $TypeError = TypeError;
var $TypeError = require('es-errors/type');

module.exports = setFunctionName(function detached() {
var O = this; // step 1
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@
"call-bind": "^1.0.8",
"define-properties": "^1.2.1",
"es-abstract": "^1.23.9",
"es-errors": "^1.3.0",
"get-proto": "^1.0.0",
"gopd": "^1.2.0",
"has-property-descriptors": "^1.0.2",
"is-shared-array-buffer": "^1.0.4",
"set-function-name": "^2.0.2"
},
Expand Down
2 changes: 1 addition & 1 deletion polyfill.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

var implementation = require('./implementation');

var supportsDescriptors = require('define-properties').supportsDescriptors;
var supportsDescriptors = require('has-property-descriptors')();
var gOPD = require('gopd');

module.exports = function getPolyfill() {
Expand Down
8 changes: 4 additions & 4 deletions shim.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
'use strict';

var supportsDescriptors = require('define-properties').supportsDescriptors;
var supportsDescriptors = require('has-property-descriptors')();
var gOPD = require('gopd');

var getPolyfill = require('./polyfill');
var defineProperty = Object.defineProperty;
var $TypeError = TypeError;
var $SyntaxError = SyntaxError;
var getProto = Object.getPrototypeOf;
var $TypeError = require('es-errors/type');
var $SyntaxError = require('es-errors/syntax');
var getProto = require('get-proto');

module.exports = function shimDetached() {
if (!supportsDescriptors || !getProto) {
Expand Down
4 changes: 2 additions & 2 deletions test/shimmed.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
require('../auto');

var test = require('tape');
var defineProperties = require('define-properties');
var callBind = require('call-bind');
var supportsDescriptors = require('has-property-descriptors')();

var isEnumerable = Object.prototype.propertyIsEnumerable;
var functionsHaveNames = require('functions-have-names')();
Expand All @@ -24,7 +24,7 @@ test('shimmed', function (t) {
s2t.end();
});

st.test('enumerability', { skip: !defineProperties.supportsDescriptors }, function (et) {
st.test('enumerability', { skip: !supportsDescriptors }, function (et) {
et.equal(false, isEnumerable.call(ArrayBuffer.prototype, 'detached'), 'ArrayBuffer#detached is not enumerable');
et.end();
});
Expand Down

0 comments on commit a9a3954

Please sign in to comment.