Skip to content

Commit

Permalink
Merge pull request #344 from esmf-org/upload_artifact_v4
Browse files Browse the repository at this point in the history
Use v4 of the upload-artifact action

The v3 upload-artifact action is deprecated and will be removed in the future (https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/). This PR updates the action to use v4.

Note possibly breaking changes given in
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md. I haven't reviewed these carefully, but at a glance I don't see use of these patterns. But @danrosen25 and @uturuncoglu you might have a better sense of this than I do.
  • Loading branch information
billsacks authored Jan 17, 2025
2 parents d366abc + 826d290 commit 78516a7
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/api-change.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
steps:

- name: Checkout Dockerfiles
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: esmf-org/esmf-containers
path: esmf-containers
Expand All @@ -41,7 +41,7 @@ jobs:
docker rm ${CID}
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: api-change
path: ${{ github.workspace }}/artifacts
6 changes: 3 additions & 3 deletions .github/workflows/build-esmf-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
steps:

- name: Checkout Dockerfiles
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: esmf-org/esmf-containers
path: esmf-containers
Expand All @@ -37,13 +37,13 @@ jobs:
docker rm ${CID}
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: esmf-docs
path: ${{ github.workspace }}/artifacts

- name: Checkout esmf-org.github.io
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: esmf-org/esmf-org.github.io
path: ${{github.workspace}}/esmf-org.github.io
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-esmpy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
steps:

- name: Checkout Dockerfiles
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: esmf-org/esmf-containers
path: esmf-containers
Expand All @@ -37,13 +37,13 @@ jobs:
docker rm ${CID}
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: esmpy-docs
path: ${{ github.workspace }}/artifacts

- name: Checkout esmpy_doc
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: esmf-org/esmpy_doc
path: ${{github.workspace}}/esmpy_doc
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test-build-spack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
steps:
# check out base repo
- name: Checkout Base Repository
uses: actions/checkout@v3
uses: actions/checkout@v4

# prepare core environment
- name: Install Core Development Tools
Expand All @@ -87,7 +87,7 @@ jobs:
# restore Intel oneAPI compiler installation from cache
- name: Restore Intel oneAPI Compiler Installation
uses: actions/cache@v3
uses: actions/cache@v4
if: ${{ startsWith(matrix.compiler, 'oneapi') }}
with:
path: /opt/intel/oneapi
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
# checkout NUOPC app prototypes
- name: Checkout NUOPC App Prototypes
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: esmf-org/nuopc-app-prototypes
path: ${{ github.workspace }}/nuopc-app-prototypes
Expand All @@ -143,7 +143,7 @@ jobs:
# push test results to artifacts
- name: Upload Artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Artifacts for ${{ matrix.compiler }} ${{ matrix.esmf }}
path: ${{ github.workspace }}/nuopc-app-prototypes/Artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
steps:

- name: Checkout Dockerfiles
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: esmf-org/esmf-containers
path: esmf-containers
Expand All @@ -32,7 +32,7 @@ jobs:
docker rm ${CID}
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-coverage
path: ${{ github.workspace }}/artifacts

0 comments on commit 78516a7

Please sign in to comment.