Single Pull for playSMS #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding playSMS as SMS provider
Adding playSMS as SMS provider
Adding playSMS as SMS provider.
Adding playSMS as SMS provider
yurikuzn
reviewed
Jul 7, 2022
|
|
||
| use Throwable; | ||
|
|
||
| class playSmsSender implements Sender |
There was a problem hiding this comment.
Class names should start with the Upper case.
yurikuzn
reviewed
Jul 7, 2022
| @@ -20,6 +20,10 @@ | |||
| "serwerSmsPassword": "Password", | |||
| "serwerSmsBaseUrl": "Base URL", | |||
| "serwerSmsSender": "Sender Name", | |||
| "serwerSmsTest": "Test" | |||
| "serwerSmsTest": "Test", | |||
There was a problem hiding this comment.
This test label seems is not needed.
There was a problem hiding this comment.
This is from your original master. It's not from me.
|
I made the requested change: classname with capital letter serwerSmsTest comes from your original master. I only modified the line by adding a colon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope it works now as expected.