Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(BLE): Add NimBLE support #10937

Draft
wants to merge 1 commit into
base: release/v3.2.x
Choose a base branch
from
Draft

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Feb 5, 2025

Description of Change

Add NimBLE implementation to BLE library.

Tests scenarios

Locally

Related links

#9878

@lucasssvaz lucasssvaz self-assigned this Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add guards":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 20ddeb0

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test Results

 62 files   62 suites   5m 40s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
153 runs  153 ✅ 0 💤 0 ❌

Results for commit 20ddeb0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
BLE/examples/BLE5_extended_scan00000000--
BLE/examples/BLE5_multi_advertising00000000--
BLE/examples/BLE5_periodic_advertising00000000--
BLE/examples/BLE5_periodic_sync00000000--
BLE/examples/Beacon_Scanner0000000000
BLE/examples/Client0000000000
BLE/examples/EddystoneTLM_Beacon0000000000
BLE/examples/EddystoneURL_Beacon0000000000
BLE/examples/Notify0000000000
BLE/examples/Scan0000000000
BLE/examples/Server0000000000
BLE/examples/Server_multiconnect0000000000
BLE/examples/UART0000000000
BLE/examples/Write0000000000
BLE/examples/iBeacon0000000000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BLE Issues related to BLE Status: In Progress Issue is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant