feat(LP_UART): Implements the ESP32-C6/ESP32-P4 Low Power UART as a possible HardwareSerial port #10967
+329
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuGlider
added
Type: Feature request
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 62 files 62 suites 6m 26s ⏱️ Results for commit 7cca982. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SuGlider
commented
Feb 13, 2025
me-no-dev
reviewed
Feb 14, 2025
cores/esp32/HardwareSerial.cpp
Outdated
| @@ -477,6 +510,12 @@ void HardwareSerial::setDebugOutput(bool en) { | |||
| if (_uart == 0) { | |||
| return; | |||
| } | |||
| #if (SOC_UART_LP_NUM >= 1) | |||
| if (_uart_nr == LP_UART_NUM_0) { | |||
There was a problem hiding this comment.
if (_uart_nr >= SOC_UART_HP_NUM) {Will handle cases where LP uarts are more than one (future)
There was a problem hiding this comment.
It can be done like that for future extension, although there no single applicable case.
I'll review it.
|
There are many checks if the uart is LP0. Can the code be made to work with "any" number LP uarts? |
Solved. It supports any number of LP UART ports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds support for ESP32-C6 and ESP32-P4 to use the LP UART peripheral as a possible
HardwareSerialport.ESP32-C6 has now a total of 3
HardwareSerialdevices: 2 HP UART ports,Serial0andSerial1plus a LP UART portSerial2ESP32-P4 has now a total of 6
HardwareSerialdevices: 5 HP UART ports,Serial0toSerial4plus a LP UART portSerial5ESP32-P4 can set any pin for being used as
Serial5RX/TX/CTS/RTX pins.ESP32-C6 must use fixed pins for
Serial2: RX(4), TX(5), RTS(2), CTS(3)Limitations:
LP UART port can't be used for logging using
log_x()LP UART is not elegible for setting loopbacks to other UART peripheral (no GPIO Matrix Signal)
Tests scenarios
Using ESP32-C6 and ESP32P4
Related links
None