Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/esp lvgl port (BSP-630) #496

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix/esp lvgl port (BSP-630) #496

merged 1 commit into from
Feb 3, 2025
+9 −8

Conversation

100312dog
Copy link
Contributor

@100312dog 100312dog commented Jan 26, 2025 •
edited
Loading

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

  1. Fix esp_lvgl_port buffer size in lvgl9, lv_color_t is 3 bytes in lvgl9, while lv_color_t is dynamic according to color format.
  2. Add esp32_s3_eye spi dma support. Currently this is not support in esp-idf. As soon as esp-idf supports it, it will take affect.

@100312dog 100312dog force-pushed the fix/esp_lvgl_port branch 2 times, most recently from 7e8e82d to 450d1ec Compare January 26, 2025 13:11
@github-actions github-actions bot changed the title Fix/esp lvgl port Fix/esp lvgl port (BSP-630) Jan 26, 2025
@tore-espressif
Copy link
Collaborator

@100312dog Could you please split this PR into 2? One for s3-eye BSP and one for esp_lvgl_port?

The changes in esp_lvgl_port LGTM, and I don't want to delay it anymore

@100312dog
Copy link
Contributor Author

@tore-espressif OK, it's done.

@tore-espressif
Copy link
Collaborator

@espzav PTAL, it seems that we allocated buffers that were too big for RGB565!

@espzav
Copy link
Collaborator

espzav commented Jan 29, 2025

@espzav PTAL, it seems that we allocated buffers that were too big for RGB565!

Yes, it seems that it is true. I am sorry for this mistake, I bad understanded before. I think that Gabor told it and I forgot fix it.

espzav
espzav approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@100312dog Thank you for this fix. LGTM

@tore-espressif tore-espressif merged commit e2c22a4 into espressif:master Feb 3, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tore-espressif tore-espressif tore-espressif approved these changes

@espzav espzav espzav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@100312dog @tore-espressif @espzav