Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcd: remove unused structs #264

Merged
merged 2 commits into from
Jan 9, 2024
Merged

lcd: remove unused structs #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d646534
lcd: remove unused structs
Lzw655 Dec 23, 2023
c28e2ab
Merge branch 'master' into bugfix/lcd_remove_unused_structs
VojtechBartoska Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions components/lcd/esp_lcd_ili9341/esp_lcd_ili9341.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,6 @@ static esp_err_t panel_ili9341_reset(esp_lcd_panel_t *panel)
return ESP_OK;
}

typedef struct {
uint8_t cmd;
uint8_t data[16];
uint8_t data_bytes; // Length of data in above data array; 0xFF = end of cmds.
} lcd_init_cmd_t;

static const ili9341_lcd_init_cmd_t vendor_specific_init_default[] = {
// {cmd, { data }, data_size, delay_ms}
/* Power contorl B, power control = 0, DC_ENA = 1 */
Expand Down
6 changes: 0 additions & 6 deletions components/lcd/esp_lcd_st7796/esp_lcd_st7796.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,6 @@ static esp_err_t panel_st7796_reset(esp_lcd_panel_t *panel)
return ESP_OK;
}

typedef struct {
uint8_t cmd;
uint8_t data[16];
uint8_t data_bytes; // Length of data in above data array; 0xFF = end of cmds.
} lcd_init_cmd_t;

static const st7796_lcd_init_cmd_t vendor_specific_init_default[] = {
// {cmd, { data }, data_size, delay_ms}
{0xf0, (uint8_t []){0xc3}, 1, 0},
Expand Down
5 changes: 5 additions & 0 deletions components/lcd/esp_lcd_st7796/test_apps/main/test_esp_lcd_st7796.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "freertos/task.h"
#include "freertos/semphr.h"
#include "driver/gpio.h"
#include "soc/soc_caps.h"
#include "esp_heap_caps.h"
#include "esp_log.h"
#include "esp_lcd_panel_ops.h"
Expand All @@ -32,7 +33,11 @@
#define TEST_PIN_NUM_LCD_DATA2 (GPIO_NUM_11)
#define TEST_PIN_NUM_LCD_DATA3 (GPIO_NUM_14)
#define TEST_PIN_NUM_LCD_DATA4 (GPIO_NUM_13)
#if CONFIG_IDF_TARGET_ESP32S2
#define TEST_PIN_NUM_LCD_DATA5 (GPIO_NUM_8)
#else
#define TEST_PIN_NUM_LCD_DATA5 (GPIO_NUM_47)
#endif
#define TEST_PIN_NUM_LCD_DATA6 (GPIO_NUM_21)
#define TEST_PIN_NUM_LCD_DATA7 (GPIO_NUM_45)
#define TEST_PIN_NUM_LCD_DATA8 (-1)
Expand Down
Loading