Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp_lcd_touch_cst816s): Fixed compilation error for IDF5.1 and lower #474

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Jan 9, 2025

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Related

Caused by #470

Change description

  • Fixed IFD5.1 compilation issue in CST816S touch controller driver
  • We need to CI tests for all components, which aren't used in BSPs. Because we need test it for all IDF versions before merge PR!

@espzav espzav force-pushed the test/touch_components_tests branch 4 times, most recently from 5be00e7 to 4651a7e Compare January 9, 2025 12:10
@espzav
Copy link
Collaborator Author

espzav commented Jan 9, 2025

@tore-espressif PTAL

@espzav
Copy link
Collaborator Author

espzav commented Jan 9, 2025

@Horion0415 FYI

@tore-espressif
Copy link
Collaborator

@espzav Thanks for the update.

About the failing CI check. The touch drivers have a compilation test here https://github.com/espressif/esp-bsp/blob/master/test_apps/components/CMakeLists.txt#L7

But for some reason, in #470 the test_apps/components application was not selected for build https://github.com/espressif/esp-bsp/actions/runs/12633599082/job/35199534536#step:5:127

I'll check why

@espzav espzav force-pushed the test/touch_components_tests branch from 4651a7e to a5bbd8d Compare January 10, 2025 08:11
@espzav espzav changed the title test(esp_lcd_touch): Add CI tests to touch components. fix(esp_lcd_touch_cst816s): Fixed compilation error for IDF5.1 and lower Jan 10, 2025
@espzav espzav force-pushed the test/touch_components_tests branch from a5bbd8d to 93145f7 Compare January 10, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants