Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lvgl_port): Changed queue to event group for speed up. #493

Merged
merged 1 commit into from
Jan 28, 2025
Merged

feat(lvgl_port): Changed queue to event group for speed up. #493

merged 1 commit into from
Jan 28, 2025

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Jan 24, 2025 •
edited
Loading

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

  • The first draft of the speed up process in LVGL task

Closes #492
Closes #497

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

Test Results

 15 files  15 suites   5m 33s ⏱️
 45 tests 22 ✅  23 💤 0 ❌
330 runs  22 ✅ 308 💤 0 ❌

Results for commit 32e9c25.

♻️ This comment has been updated with latest results.

@espzav espzav force-pushed the feat/lvgl_port_events branch 3 times, most recently from 1e9a59e to b7a62c9 Compare January 24, 2025 14:29
@wreyford
Copy link

Thx. That sorts the unresponsiveness.

@espzav
Copy link
Collaborator Author

espzav commented Jan 27, 2025

This solution takes more RAM (more than 1KB in IRAM) than using queue. This solution should be faster in some cases.
@wreyford @tore-espressif @igrr Do we want to use it or no?

@wreyford
Copy link

This solution takes more RAM (more than 1KB in IRAM) than using queue. This solution should be faster in some cases. @wreyford @tore-espressif @igrr Do we want to use it or no?

The fix makes our software usable. Without it, touch is for all practicality unusable. We have extensively tested it and are very happy with this current implementation. Reverting back will not solve the problem for us, and would require another solution then.

tore-espressif
tore-espressif reviewed Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

If the increased RAM usage is because of FreeRTOS internal timer task, then IMO it is OK. Many application will use the timer task anyway...

components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c Outdated Show resolved Hide resolved
components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c Show resolved Hide resolved
@espzav espzav force-pushed the feat/lvgl_port_events branch 5 times, most recently from b0a1a84 to 4d22fc8 Compare January 28, 2025 10:32
@espzav espzav force-pushed the feat/lvgl_port_events branch from 4d22fc8 to 32e9c25 Compare January 28, 2025 13:15
@espzav espzav merged commit dddc990 into master Jan 28, 2025
35 checks passed
@espzav espzav deleted the feat/lvgl_port_events branch January 28, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tore-espressif tore-espressif tore-espressif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@espzav @wreyford @tore-espressif