Upon Parent re-connection after a channel switch g_rootless_flag required to be updated on Root as well as on Leaf. #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the file mwifi.c
How to Recreate the Scenario:
so MESH_EVENT_NETWORK_STATE event occurs and so g_rootless_flag is now set to true for all leafs.
Line 177: g_rootless_flag required to be updated on both Root and Leaf If the parent get re-connected after a channel switch.
What happens without this change:
at Line 861:
MDF_ERROR_CHECK(to_root && g_rootless_flag, MDF_ERR_MWIFI_NO_ROOT, "Current network has no root");
Because the leaf do not have g_rootless_flag set to false after the channel switch - Leaf will not be able to send data to the root and it will keep sending an error message stating "Current network has no root".
So proposed change is working for me and has resolved the issue. Please verify this and update here if espressif team is good with this change.
Thank you.