Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metadata: know if a file exist and is not empty #191

Open
Tracked by #3739
AntoineAugusti opened this issue Jan 23, 2024 · 2 comments
Open
Tracked by #3739

New metadata: know if a file exist and is not empty #191

AntoineAugusti opened this issue Jan 23, 2024 · 2 comments

Comments

@AntoineAugusti
Copy link
Member

AntoineAugusti commented Jan 23, 2024

Add the following metadata, to know if these "extra files" are present and not empty:

  • has_fare_attributes (named has_fares currently, maybe duplicate?)
  • has_fare_rules
  • has_transfers

Maybe consider adding, has_* metadata attributes for all structures/files?

pub has_fares: bool,
pub has_shapes: bool,
pub has_pathways: bool,

@antoine-de
Copy link
Member

I'm not really sure if we want to have this for all files, I think it's interesting to have some general capabilities like has_fare if there are one fare file and we can maybe add on top of that more statistics about the number of objects in the dataset?

For the moment we have:

stop_areas_count
stop_points_count
stops_with_wheelchair_info_count
lines_count
trips_count
trips_with_bike_info_count
trips_with_wheelchair_info_count
trips_with_shape_count
trips_with_trip_headsign_count
lines_with_custom_color_count

maybe we can put all those in a count object (keeping the old values for retrocompatibilities), and add more statistics ?

like the number of transfers, fare_rules and fare_attributes? (+routes_with_route_long_name_count asked in #190 and routes_with_route_short_name_count asked in #189 and trips_with_trip_headsign_count asked in #188 )

@AntoineAugusti
Copy link
Member Author

@antoine-de Reading this after looking at your PR, that's a good move to introduce a stats object!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants