Move stats in a metadata.stats objects
#192
Conversation
And add more counts: * trips_with_trip_headsign_count: usize, * lines_with_short_name_count: usize, * lines_with_long_name_count: usize, * transfers_count: usize, * fares_attribute_count: usize, There is no `fare_rules` yet, they are not handled by gtfs structures yet
|
I added the fare rules count too as it has been merged in gtfs-structures (in rust-transit/gtfs-structure#157) By curiosity, do you know if there are producers that have implemented the fares v2 model? |
|
Thanks for the changes!
Not yet 😢 Grand Est / Fluo may be the first in the coming months, they are working with Cityway on it. |
|
|
||
| pub stats: Stats, | ||
| // legacy fields, now counter should be in stats | ||
| pub stop_areas_count: usize, |
There was a problem hiding this comment.
are those legacy fields used elsewhere, shouldn’t they be removed ?
There was a problem hiding this comment.
it's to maintain API retro compatibility, I don't think we can remove those
There was a problem hiding this comment.
@AntoineAugusti do you think we could remove those legacy fields after the integration in the transport site is done ?
I'm always wary of API breaking, but @Tristramg might have a point that this should not impact anybody other than https://github.com/etalab/transport-site
There was a problem hiding this comment.
Yup, the legacy *_count fields outside of the new stats key can be removed in the next PR!
|
@antoine-de Can you push the latest commit on the |
|
done, sorry forgot this |
|
nice, can I merge? |
|
Yup, looks good. Should we bump the version? Or in the next PR when removing attributes? |
|
since it's a binary and not a library, we have never kept clean version in this, but you're right, maybe we can update the version after removing the fields |
And add more counts:
There is no
fare_rulesyet, they are not handled by gtfs structures yetfixes #188 #189 #190 and partially #191 since we need to handle
fare_rules