-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node syncing and weak subjectivity #312
Merged
taxmeifyoucan
merged 6 commits into
eth-protocol-fellows:main
from
chirag-parmar:syncing
Jan 28, 2025
Merged
node syncing and weak subjectivity #312
taxmeifyoucan
merged 6 commits into
eth-protocol-fellows:main
from
chirag-parmar:syncing
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9fdc6e
to
5d5d364
Compare
raxhvl
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is well written. I have left my review. Thanks!
@chirag-parmar Ping on this one, are you planning to continue? |
@taxmeifyoucan yes, apologies it got super busy the past few months. I'll wrap this up by the end of the week |
bbf2767
to
76b46b0
Compare
76b46b0
to
f2cd551
Compare
Thank you Chirag, this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: