Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Geth to execution client #343

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

rayjun
Copy link
Contributor

@rayjun rayjun commented Feb 6, 2025

Using Geth here is no longer appropriate. It should refer to all execution clients

Copy link
Contributor

@SiddharthV1 SiddharthV1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though you are right about the fact that one should try and address architectural commonalities between clients, the pools themselves might not be well specified across clients . What has to be investigated first is if all the execution clients are employing the legacy pool as defined here or are there differences... if there are, they should be highlighted here

@rayjun
Copy link
Contributor Author

rayjun commented Feb 6, 2025

Yes, you're right. However, the transaction pool here should be an abstract concept. Even if it has different names in different client implementations, it should exist architecturally, just like the explanation of STF in the above text.

@taxmeifyoucan
Copy link
Contributor

+1 I agree we should just use execution client and general term here. Maybe just add a clarification later that different clients implementation details differ and this is example of geth?

@taxmeifyoucan taxmeifyoucan merged commit 1e44b07 into eth-protocol-fellows:main Feb 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants