Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html export fix #38

Merged
merged 5 commits into from
Dec 17, 2020
Merged

Html export fix #38

merged 5 commits into from
Dec 17, 2020

Conversation

ilmartyrk
Copy link
Contributor

FIX for #7

@JohnMcLear
Copy link
Member

just check for javascript injection attacks here IE "><script='alrert("foo")'> in content

@ilmartyrk ilmartyrk mentioned this pull request Dec 17, 2020
Merged
@ilmartyrk
Copy link
Contributor Author

@JohnMcLear what should be the behaviour if injection exists?

@JohnMcLear
Copy link
Member

Security.HTMLEscape prolly

@ilmartyrk
Copy link
Contributor Author

It will also escape any html added by other plugins eg. ep_font_color

@JohnMcLear
Copy link
Member

It will also escape any html added by other plugins eg. ep_font_color

Very true ;(

Okay never mind 👍 we should be good with this as is then?

@JohnMcLear JohnMcLear merged commit 384ae97 into master Dec 17, 2020
@rhansen rhansen deleted the html_export_fix branch December 18, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilmartyrk @JohnMcLear