Fix double record save on Craft 2 > 3 upgrade

Fixes #153
ethercreative · Apr 5, 2019 · cea5a8b · cea5a8b
1 parent c7347f9
commit cea5a8b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 3.4.11 - 2019-04-05
+### Fixed
+- Map records are no longer double saved when upgrading to from Craft 2 to 3
+
 ## 3.4.10 - 2019-04-04
 ### Fixed
 - Map records are no longer double saved when upgrading to >3.4.x

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
   "name": "ether/simplemap",
   "description": "A beautifully simple Map field type for Craft CMS 3",
-  "version": "3.4.10",
+  "version": "3.4.11",
   "type": "craft-plugin",
   "license": "MIT",
   "minimum-stability": "dev",

diff --git a/src/migrations/m190226_143809_craft3_upgrade.php b/src/migrations/m190226_143809_craft3_upgrade.php
@@ -101,20 +101,6 @@ private function _upgrade2 ()
 		    ]);
 
 		    $elements->saveElement($map, false);
-
-		    $record              = new Map();
-		    $record->id          = $map->id;
-		    $record->ownerId     = $map->ownerId;
-		    $record->ownerSiteId = $map->ownerSiteId;
-		    $record->fieldId     = $map->fieldId;
-
-		    $record->lat     = $map->lat;
-		    $record->lng     = $map->lng;
-		    $record->zoom    = $map->zoom;
-		    $record->address = $map->address;
-		    $record->parts   = $map->parts;
-
-		    $record->save();
 	    }
 
 	    $this->dropTable('{{%simplemap_maps}}');