-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-7821: Remove Call Struct from Specification #883
base: master
Are you sure you want to change the base?
Conversation
Why does it need to match the 7579 struct? It's just a naming thing, no? |
I just think it is helpful to match the same struct since the ERC is already referencing 7579. Really, call struct could just be removed from this ERC since the goal isn't to standardize the call struct, it is to standardize the execution interface. |
It references 7579 on the |
I prefer You can always rename it to Solady’s LibERC7579 doesn’t have a We can add a note saying that this is the |
@Vectorized what if we remove the Call struct from the specification section, since you are trying to standardize the execution interface and not the call struct. But then you can use the Call struct in the reference implementation? |
Yeah, don't think it would hurt to remove L41-45 as it's not being used in the Overview. We can leave the Reference Implementation as-is. |
fb7a2c8
to
3666ca3
Compare
File
|
Updated the PR based on the convo. The change now just removes the |
Update (Feb 7, 2025): Based on convo, this PR just removes the
Call
struct from the Specification section since it is not needed to standardize the execution interface. The Reference Implementation has been left unchanged.ERC-7821 implies using a
Call
struct. ERC-7579 already leverages anExecution
struct in their reference implementation.This is to change the
Call
struct to the referenced ERC-7579Execution
struct.Another option is to remove the struct from this standard altogether since you are really trying to standardize the execute interface