[WIP] Support the standard JSON via compile() too #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs tests. |
axic
force-pushed
the
better-wrapper
branch
2 times, most recently
from
62a6309 to
1597b73
Compare
axic
changed the title
axic
force-pushed
the
better-wrapper
branch
4 times, most recently
from
b7549b0 to
e8ece8b
Compare
chriseth
reviewed
Mar 7, 2018
|
|
||
| if (isStandardJSON) { | ||
| // NOTE: takes second argument as "readCallback" | ||
| return JSON.parse(compileStandardWrapper(input, optimise)); |
There was a problem hiding this comment.
compileStandardWrapper is only assigned in line 83 / 105
chriseth
suggested changes
Mar 7, 2018
Probably it isn't yet, it is more about discussing the API. Eventually at 0.5.0 I'd like to replace |
|
Yes, I think it is a good idea to make compile to also take json-io. |
|
This needs tests. |
axic
commented
Sep 26, 2018
| @@ -104,6 +104,19 @@ There is also a direct method, `compileStandard`, which is only present on recen | |||
|
|
|||
| Starting from version 0.4.20 a Semver compatible version number can be retrieved on every compiler release, including old ones, using the `semver()` method. | |||
|
|
|||
| #### From version 0.4.21 | |||
There was a problem hiding this comment.
Oh man, only if we'd have merged this at 0.4.21, it wouldn't be too big a breaking change anymore :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #120 and ethereum/solidity#3452