Remove old libsolc API (compileJSON, compileJSONMulti, compileJSONCallback) #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Sep 27, 2018
| s_outputBuffer = compileMulti(_input, _optimize, _readCallback); | ||
| return s_outputBuffer.c_str(); | ||
| } | ||
| extern char const* compileStandard(char const* _input, CStyleReadFileCallback _readCallback) noexcept |
There was a problem hiding this comment.
I'm kind of leaning towards keeping this single line for now (during the release candidate time) so that projects can easily test it with truffle.
chriseth
reviewed
Sep 27, 2018
Changelog.md
Outdated
| @@ -11,6 +11,8 @@ How to update your code: | |||
|
|
|||
| Breaking Changes: | |||
| * ABI Encoder: Properly pad data from calldata (``msg.data`` and external function parameters). Use ``abi.encodePacked`` for unpadded encoding. | |||
| * C API (``libsolc``): Removed the ``version``, ``license``, ``compileSingle``, ``compileJSON``, ``compileJSONCallback`` methods | |||
There was a problem hiding this comment.
Perhaps emphasize that this also applies to solc-js if used directly?
Codecov Report
@@ Coverage Diff @@
## develop #5105 +/- ##
===========================================
- Coverage 88.1% 88.01% -0.09%
===========================================
Files 323 322 -1
Lines 32647 32319 -328
Branches 3873 3849 -24
===========================================
- Hits 28763 28447 -316
+ Misses 2585 2581 -4
+ Partials 1299 1291 -8
|
chriseth
previously approved these changes
Oct 30, 2018
chriseth
force-pushed
the
libsolc-api
branch
2 times, most recently
from
174bfb1 to
8785f6e
Compare
|
I'm wondering whether the failure on travis is a problem or not. |
|
I replaced the "npm install solc" by a 'git clone' so we get the updated solc-js version, this should fix the travis tests. |
|
Cannot comment on the line, but the storebytecode needs to be fixed
This doesn't point to the |
|
Rebased and fixed |
chriseth
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5104 and ethereum/solc-js#259.
Closes #3452.