style: add clippy lint uninlined-format-args

ethportal-api/src/lib.rs

@@ -2,6 +2,7 @@
 //!
 //! `ethportal_api` is a collection of Portal Network APIs and types.
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 #[macro_use]
 extern crate lazy_static;

ethportal-api/src/types/consensus/fork.rs

@@ -45,7 +45,7 @@ impl FromStr for ForkName {
         Ok(match fork_name.to_lowercase().as_ref() {
             "bellatrix" | "merge" => ForkName::Bellatrix,
             "capella" => ForkName::Capella,
-            _ => return Err(format!("unknown fork name: {}", fork_name)),
+            _ => return Err(format!("unknown fork name: {fork_name}")),
         })
     }
 }

ethportal-api/src/types/content_key/state.rs

@@ -140,7 +140,7 @@ impl fmt::Display for StateContentKey {
             }
         };
 
-        write!(f, "{}", s)
+        write!(f, "{s}")
     }
 }
 

ethportal-api/src/utils/serde/hex_fixed_vec.rs

@@ -19,5 +19,5 @@ where
 {
     let vec = deserializer.deserialize_string(PrefixedHexVisitor)?;
     FixedVector::new(vec)
-        .map_err(|e| serde::de::Error::custom(format!("invalid fixed vector: {:?}", e)))
+        .map_err(|e| serde::de::Error::custom(format!("invalid fixed vector: {e:?}")))
 }

ethportal-api/src/utils/serde/hex_var_list.rs

@@ -20,5 +20,5 @@ where
 {
     let bytes = deserializer.deserialize_str(PrefixedHexVisitor)?;
     VariableList::new(bytes)
-        .map_err(|e| serde::de::Error::custom(format!("invalid variable list: {:?}", e)))
+        .map_err(|e| serde::de::Error::custom(format!("invalid variable list: {e:?}")))
 }

ethportal-peertest/src/lib.rs

@@ -1,3 +1,4 @@
+#![warn(clippy::uninlined_format_args)]
 #![cfg(unix)]
 pub mod constants;
 pub mod scenarios;

portal-bridge/src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 pub mod beacon_bridge;
 pub mod bridge;

portalnet/src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 pub mod config;
 pub mod discovery;

portalnet/src/overlay.rs

@@ -552,7 +552,7 @@ where
         stream
             .read_to_eof(&mut data)
             .await
-            .map_err(|err| OverlayRequestError::UtpError(format!("{:?}", err)))?;
+            .map_err(|err| OverlayRequestError::UtpError(format!("{err:?}")))?;
 
         Ok(data)
     }

portalnet/src/overlay_service.rs

@@ -1758,7 +1758,7 @@ where
                 } else if let Some(err) = err.downcast_ref::<String>() {
                     err.clone()
                 } else {
-                    format!("{:?}", err)
+                    format!("{err:?}")
                 };
                 debug!(err, content_key = ?content_keys_string[index], "Process uTP payload tokio task failed:");
                 None

portalnet/src/storage.rs

@@ -660,7 +660,7 @@ impl PortalStorage {
                     ),
                     // Received data of size other than 32 bytes.
                     length => {
-                        let err = format!("content ID of length {} != 32", length);
+                        let err = format!("content ID of length {length} != 32");
                         return Err(ContentStoreError::InvalidData { message: err });
                     }
                 };

portalnet/src/types/messages.rs

@@ -198,7 +198,7 @@ impl fmt::Display for ProtocolId {
             ProtocolId::Beacon => "Beacon",
             ProtocolId::Utp => "uTP",
         };
-        write!(f, "{}", protocol)
+        write!(f, "{protocol}")
     }
 }
 
@@ -389,7 +389,7 @@ impl From<Pong> for Value {
 
                 Value::Object(result)
             }
-            Err(msg) => Value::String(format!("Unable to ssz decode data radius!: {:?}", msg)),
+            Err(msg) => Value::String(format!("Unable to ssz decode data radius!: {msg:?}")),
         }
     }
 }
@@ -434,7 +434,7 @@ impl TryFrom<NodesHelper> for Nodes {
             .into_iter()
             .map(|bytes| {
                 rlp::decode(&bytes)
-                    .map_err(|e| DecodeError::BytesInvalid(format!("rlp decoding failed: {}", e)))
+                    .map_err(|e| DecodeError::BytesInvalid(format!("rlp decoding failed: {e}")))
             })
             .collect::<Result<_, _>>()?;
 

rpc/src/fetch.rs

@@ -46,8 +46,7 @@ pub async fn find_header_by_hash(
     match header {
         HistoryContentValue::BlockHeaderWithProof(h) => Ok(h.header),
         wrong_val => Err(RpcServeError::Message(format!(
-            "Internal trin error: got back a non-header from a key that must only point to headers; got {:?}",
-            wrong_val
+            "Internal trin error: got back a non-header from a key that must only point to headers; got {wrong_val:?}"
         ))),
     }
 }
@@ -63,8 +62,7 @@ pub async fn find_block_body_by_hash(
     match body {
         HistoryContentValue::BlockBody(body) => Ok(body),
         wrong_val => Err(RpcServeError::Message(format!(
-            "Internal trin error: got back a non-body from a key that must only point to bodies; got {:?}",
-            wrong_val
+            "Internal trin error: got back a non-body from a key that must only point to bodies; got {wrong_val:?}"
         ))),
     }
 }

rpc/src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 mod beacon_rpc;
 mod builder;
@@ -56,7 +57,7 @@ pub async fn launch_jsonrpc_server(
                 // not implemented
             }
             BEACON_NETWORK => modules.push(PortalRpcModule::Beacon),
-            _ => panic!("Unexpected network type: {}", network),
+            _ => panic!("Unexpected network type: {network}"),
         }
     }
 

src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 use std::sync::Arc;
 

trin-beacon/src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 pub mod events;
 mod jsonrpc;

trin-history/src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 pub mod events;
 mod jsonrpc;

trin-state/src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 use std::sync::Arc;
 

trin-utils/src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 pub mod log;
 pub mod version;

trin-validation/src/lib.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::unwrap_used)]
+#![warn(clippy::uninlined_format_args)]
 
 pub mod accumulator;
 pub mod constants;

utp-testing/src/lib.rs

@@ -1,3 +1,5 @@
+#![warn(clippy::uninlined_format_args)]
+
 extern crate core;
 
 pub mod cli;