feat: add retries to bridge gossip, with rfc network checks #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
bridge-gossip-retry
branch
from
202d25a to
795182f
Compare
njgheorghita
requested review from
ogenev,
carver,
KolbyML and
mrferris
and removed request for
ogenev and
carver
ogenev
approved these changes
Nov 23, 2023
portal-bridge/src/stats.rs
Outdated
| // don't double count an enr if multiple clients offered the same content | ||
| // to a peer | ||
| if !content_stats.offered.contains(&enr) { | ||
| content_stats.offered.push(enr); |
There was a problem hiding this comment.
nit: If we want the uniqueness of values, we can use HashSet instead of Vec for offered, accepted and transferred. This way, we can remove the if statement to check for existing Enr.
| // if not, make rfc request to see if data is available on network | ||
| let result = | ||
| BeaconNetworkApiClient::recursive_find_content(&client, content_key.clone()).await; | ||
| if let Ok(PossibleBeaconContentValue::ContentPresent(_)) = result { |
njgheorghita
force-pushed
the
bridge-gossip-retry
branch
from
795182f to
f951bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Bridges only made one gossip attempt, and gave up. This isn't ideal. The bridge gossip strategy has been updated to...
Testing locally, I've seen all kinds of cases, which is encouraging. eg.
How was it fixed?
Updated beacon and history bridge with the above functionality.
To-Do