fix: filter out disconnected nodes on Node/(Content Enr) response #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
force-pushed
the
filter-disconnected-nodes
branch
2 times, most recently
from
63fbbf5 to
c8ebd0e
Compare
njgheorghita
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Looks good to me! But I'd recommend waiting for a review from @mrferris since iiuc he was working on this during devconnect and he might have found some gotchas that I'm missing
KolbyML
force-pushed
the
filter-disconnected-nodes
branch
2 times, most recently
from
0dff9ee to
576d5d3
Compare
KolbyML
changed the title
KolbyML
force-pushed
the
filter-disconnected-nodes
branch
from
576d5d3 to
1e721ca
Compare
mrferris
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
during devconnect Mike brought up glados's cartographer was trying to ping 1800 enrs, because trin nodes were returning disconnect nodes.
I don't think we should remove the last resort of using disconnected nodes to initialize a RFC/RFN. Since the last resort will only be used if there are 0 connected nodes in the whole routing table which should only happen on startup.
in short I believe this is the right solution
This can also be in glados audits
In this picture the Trin node is returning Enr's of disconnected nodes which haven't run for over a month. The trin node returned these because it sorted by distance without filtering out disconnected first. This PR adds the filter so that should no longer happen.
How was it fixed?
by filtering out disconnected nodes by status
I applied to filter to both the Nodes response and the Content Enr Response