feat: add an instrument to portal-bridge for more clear logs #1081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I was trying to read through bridge logs and I couldn't tell if they were coming from the history or beacon bridge. This makes grepping and debugging hard.
How was it fixed?
with this change all the logs generated by the history bridge are marked by history and all the logs generated by the beacon bridge are tagged with beacon
previously it was unclear for example which bridge generated
DEBUG: portal_bridge::gossip
, but now it is markedDEBUG history: portal_bridge::gossip
This also improves grepibility since you can just grep logs by network which is awesome.