fix: add deployment steps for updating glados' trin node #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
requested changes
Jan 27, 2024
There was a problem hiding this comment.
Trin on glados hasen't been updated in 6 weeks. These instructions don't work to pull the latest image of Trin. I found the fix and will make a PR on the cluster repo.
I think instead of sshing in we should just use anisble like we do for trin.
For
- consistency
- reproducibility
- etc
|
Here is a PR to supercede this one #1120 I believe it is best practice to do glados deploys through ansible instead of sshing and running commands. Also keeping our deployment structure consistent is important as well. Excluding the issue in the ansible and in this PR's instructions here which won't update the trin node. Which is a seperate issue introduced when we added fluffy support to glados's docker compose file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Trin deployment steps leave glados's trin node un-updated
To-Do