fix: cross build ci required for releases + remove const_format #1643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There was a bug in #1615 which caused https://github.com/ethereum/trin/actions/runs/12834319209/job/35791388762 release ci to fail, on trying to build.
How was it fixed?
I removed const_format cause it wasn't needed and also fixed some indexing
I tested on my forked github repo and it works
release: https://github.com/KolbyML/trin/releases
release branch: https://github.com/KolbyML/trin/tree/fix-cross-build
ci working: https://github.com/KolbyML/trin/actions/runs/12835484962/job/35796339052
I tested the binary built locally
and the short commit matches