Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker portal-bridge can't find genesis.json #1648

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Jan 25, 2025

What was wrong?

Milos noticed that the 1M state bridges weren't running after the refactor
image

How was it fixed?

Stop reading the genesis file and use include_str! I am using this upstream for trin-execution and it is also common practice in reth for the genesis file.

Just to point out we can't use a const I believe, include_str errored saying we must use a string literal

@KolbyML KolbyML requested a review from morph-dev January 25, 2025 13:55
@KolbyML KolbyML self-assigned this Jan 25, 2025
Copy link
Collaborator

@morph-dev morph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 (assuming all tests are passing)

@KolbyML KolbyML merged commit d8d3550 into ethereum:master Jan 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants