Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set gas_price when handling eth_call #1649

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

morph-dev
Copy link
Collaborator

What was wrong?

We can't execute transaction post EIP-1559 without setting gas price. And gas price has to be at least base fee.

How was it fixed?

If unset, set the gas price to base fee.

Also added debug logging for easier debugging eth_call requests.

@morph-dev morph-dev self-assigned this Jan 25, 2025
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@morph-dev morph-dev merged commit e7eba51 into ethereum:master Jan 25, 2025
11 checks passed
@morph-dev morph-dev deleted the gas_price branch January 25, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants