Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance during long unfinality periods #224

Merged
merged 15 commits into from
Jan 27, 2025

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Jan 24, 2025

follow up PR on #223 with more performance improvements and fixes for long unfinality periods as currently seen on devnet-5:

  • improve GetEpochStats performance (avoid expensive chain traversal)
  • improve GetCanonicalHead performance (sort head candidates once only)
  • store proposer duties to db to avoid expensive recalculation on startup
  • fix SQL issue when finalizing a epoch without canonical blocks (ERROR: syntax error at or near \")\" (SQLSTATE 42601))
  • fixed updating the fork_id for canonical blocks in the finalization handler

@pk910 pk910 added the build-docker-image Automatically build docker image for PR branch label Jan 24, 2025
@pk910 pk910 force-pushed the pk910/unfinality-performance-fixes branch from 9ccc0c8 to 7d6ca91 Compare January 24, 2025 16:54
@pk910 pk910 marked this pull request as ready for review January 24, 2025 17:36
@pk910 pk910 force-pushed the pk910/unfinality-performance-fixes branch from 84df105 to d7c38e8 Compare January 24, 2025 20:24
@pk910 pk910 merged commit bade6c9 into master Jan 27, 2025
13 checks passed
@pk910 pk910 deleted the pk910/unfinality-performance-fixes branch January 27, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-docker-image Automatically build docker image for PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants