-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve performance during long unfinality periods #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk910
added
the
build-docker-image
Automatically build docker image for PR branch
label
Jan 24, 2025
pk910
force-pushed
the
pk910/unfinality-performance-fixes
branch
from
January 24, 2025 16:54
9ccc0c8
to
7d6ca91
Compare
pk910
force-pushed
the
pk910/unfinality-performance-fixes
branch
from
January 24, 2025 20:24
84df105
to
d7c38e8
Compare
skylenet
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up PR on #223 with more performance improvements and fixes for long unfinality periods as currently seen on devnet-5:
GetEpochStats
performance (avoid expensive chain traversal)GetCanonicalHead
performance (sort head candidates once only)ERROR: syntax error at or near \")\" (SQLSTATE 42601)
)