fix: remove some UUOC #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwrd
approved these changes
Jan 8, 2025
given that run_sh uses /bin/sh, which doesn't support pipefail option, the previous state allowed failures to not stop kurtosis execution (the whole step itself didn't fail). Beyond the inconvenience of having to scroll up to see the real failure, it also potentially allowed kurtosis to *cache* the faulty step, which would be very confusing at the next run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given that run_sh uses /bin/sh, which doesn't support pipefail option,
the previous state allowed failures to not stop kurtosis execution
(the whole step itself didn't fail).
Beyond the inconvenience of having to scroll up to see the real
failure, it also potentially allowed kurtosis to cache the faulty
step, which would be very confusing at the next run.