Remove some dead code #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you test this on paper mario too? us only is fine. I am worried that not having the symbols on splat's side will fail some of the gfx segments |
|
splat is still getting the symbols from spimdisasm. The cleanup removes giving back those symbols back to spimdisasm. Either way, I tested both paper mario us and jp and both matched |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted there's some dead code floating around and decided to clean it up.
The code from
codesubsegment.pywas just wasting runtime since it was creating jumptable symbols based on spimdisasm's analysis and then passing those new symbols back to spimdisasm, essentially a no-opGot curious about it and compared the current main with this branch on drmario64 and af to see if there was a noticeable time improvement.
0m4.643s->0m4.425s: 4.7% faster0m49.212s->0m47.631s: 3.21% faster