Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filename attribute for symbols #358

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Conversation

AngheloAlf
Copy link
Collaborator

A way to handle mangled symbols names that may be invalid as filepaths.

I tried to make the error message to explain the issue as much as possible.
It looks like this

Loading symbols (elf_symbol_addrs):   0%|                                        | 0/12114 [00:00<?, ?it/s]
error reading config/us/elf_symbol_addrs.txt, line 119:
        __opPCc__Q23std34_RefCountedPtr<c,Q23std9_Array<c>>CFv = 0x00202850; // size:0x1C type:func bind = <processor specific> 13
Ilegal symbol filename detected!
  The symbol
    __opPCc__Q23std34_RefCountedPtr<c,Q23std9_Array<c>>CFv
  exceeds the 255 bytes filename limit that most OS imposes or uses illegal characters,
  which will be a problem when writing the symbol to its own file.
  To fix this specify a `filename` for this symbol, like `filename:func_00202850`.
  Make sure the filename does not exceed 253 bytes nor it contains any of the following characters:
    ['<', '>', ':', '"', '/', '\\', '|', '?', '*']

CHANGELOG.md Outdated Show resolved Hide resolved
@ethteck ethteck merged commit d28aceb into ethteck:main Mar 19, 2024
6 checks passed
@AngheloAlf AngheloAlf deleted the sym_filename branch March 19, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants