Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add settings to toggle %gp_rel usage on generated assembly #392

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

AngheloAlf
Copy link
Collaborator

@AngheloAlf AngheloAlf commented Aug 8, 2024

Fixes #391

This is still a Work-In-Progress.

I'm opening this PR in the current state since I'm looking for people to actually test that this new feature is working properly.

To test this PR:

  • Install / checkout this PR.
    python3 -m pip uninstall splat64
    python3 -m pip install git+https://github.com/AngheloAlf/splat.git@gpRelHack
    
  • Set use_gp_rel_macro_nonmatching: False on your yaml
  • Disable your own custom %gp_rel patching system.

If everything works as it should then running splat and then building your project should Just Work ™️. Please let me know if it doesn't.

@AngheloAlf AngheloAlf marked this pull request as ready for review August 9, 2024 15:23
@AngheloAlf
Copy link
Collaborator Author

undrafted the PR

@ethteck
Copy link
Owner

ethteck commented Aug 9, 2024

looks grood, just need changelog

@ethteck ethteck merged commit f37e767 into ethteck:main Aug 9, 2024
7 checks passed
@AngheloAlf AngheloAlf deleted the gpRelHack branch August 9, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make %gp_rel access configurable between asm and nonmatchings asm
2 participants