Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix $gp calculation when addiu value is negative #393

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Fix $gp calculation when addiu value is negative #393

merged 4 commits into from
Aug 10, 2024

Conversation

mkst
Copy link
Collaborator

@mkst mkst commented Aug 10, 2024

No description provided.

@ethteck
Copy link
Owner

ethteck commented Aug 10, 2024

Would you mind adding a changelog entry and bumping the version? I'll put out another release after merging this

@AngheloAlf
Copy link
Collaborator

getImmediate is deprecated. getProcessedImmediate is preferred since it does the two complement calculation on signed instructions

@ethteck ethteck merged commit e2a638e into main Aug 10, 2024
14 checks passed
@ethteck ethteck deleted the bugfix-gp-calc branch August 10, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngheloAlf AngheloAlf AngheloAlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkst @ethteck @AngheloAlf