chore: clean up inter-project dependencies #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused dependencies between the specs2 modules. This change is "breaking" in the sense that projects using the specs2 library may have to be more explicit with their specs2 dependency declarations; most notably `specs2-core`, `specs2-analysis` and `specs2-matcher-extra` may need to be added explicitly if e.g. only `specs2-html`, `specs2-gwt` or `specs2-mock` were depended on before.
etorreborre
merged commit 3680da1
into
etorreborre:specs2-4.x-maintenance
4 checks passed
|
I think that this is ok because I suspect that very few people are using those modules. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused dependencies between the specs2 modules. This change is "breaking" in the sense that projects using the specs2 library may have to be more explicit with their specs2 dependency declarations; most notably
specs2-core,specs2-analysisandspecs2-matcher-extramay need to be added explicitly if e.g. onlyspecs2-html,specs2-gwtorspecs2-mockwere depended on before.This change originates from the observation that
htmlcurrently pulls in ascala-compilerdependency, which came via (form,)matcherExtraandanalysis, which are all not actually needed forhtml. The same holds true forformandgwt.For a full list of changes, refer to the diff.
(I don't know if this kind of "breaking change" is acceptable. If not, feel free to close this PR. If only some of these changes are wanted, I can change it accordingly. I will wait for feedback before making a similar change for the master branch.)