-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update junit-platform-engine to 1.11.4 #1291
Update junit-platform-engine to 1.11.4 #1291
Conversation
WalkthroughThe pull request introduces a minor version update for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
project/depends.scala
(1 hunks)
π Additional comments (1)
project/depends.scala (1)
26-26
: Verify compatibility with the new version
Let's verify if there are any breaking changes or known issues with this version update.
β Verification successful
Let me gather more information about the current version and its usage.
Based on the search results, I can now generate a final response since we have sufficient information about the JUnit usage in the codebase.
Version update appears safe to proceed
The codebase shows JUnit integration primarily through test runners and specifications, with no direct engine-specific implementation dependencies. The update to junit-platform-engine 1.11.4 is being used alongside JUnitVintage, which is a standard pattern. The usage patterns found in the codebase (mainly through @RunWith
annotations and specification classes) are stable APIs that are unlikely to be affected by this minor version update.
π Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for compatibility issues and release notes for junit-platform-engine 1.11.4
# Check the GitHub releases page for JUnit Platform
gh api \
-H "Accept: application/vnd.github+json" \
repos/junit-team/junit5/releases | \
jq '.[] | select(.tag_name | contains("r1.11.4")) | {name: .name, body: .body}'
# Look for any existing usage patterns that might be affected
rg -A 3 "junit-platform-engine" --type scala
Length of output: 898
Script:
#!/bin/bash
# Check the current version being used
rg -p "junit-platform-engine.*\d+\.\d+\.\d+" --type scala
# Check for any test configurations or specific engine usage
rg -p "JUnitEngine|@Test|@RunWith" --type scala -A 3
# Look for any build files that might show dependency relationships
fd "build.sbt|\.scala$" --type f --exec grep -l "junit"
Length of output: 2885
@@ -23,7 +23,7 @@ object depends { | |||
|
|||
// used in specs2-junit | |||
val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.3" | |||
val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.3") | |||
val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version mismatch between JUnit dependencies
The junit-platform-engine
is being updated to version 1.11.4
, while junit-vintage-engine
remains at version 5.11.3
. These related JUnit dependencies should maintain version alignment to ensure compatibility.
Apply this diff to align the versions:
- val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.3"
- val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.4")
+ val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.4"
+ val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.4")
Committable suggestion skipped: line range outside the PR's diff.
About this PR
π¦ Updates org.junit.platform:junit-platform-engine from
1.11.3
to1.11.4
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
Summary by CodeRabbit
junit-platform-engine
dependency from1.11.3
to1.11.4
.