Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update junit-platform-engine to 1.11.4 #1291

Conversation

scala-steward
Copy link
Contributor

@scala-steward scala-steward commented Dec 17, 2024

About this PR

πŸ“¦ Updates org.junit.platform:junit-platform-engine from 1.11.3 to 1.11.4

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.junit.platform", artifactId = "junit-platform-engine" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.junit.platform", artifactId = "junit-platform-engine" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Summary by CodeRabbit

  • Chores
    • Updated the version of the junit-platform-engine dependency from 1.11.3 to 1.11.4.

Copy link

coderabbitai bot commented Dec 17, 2024

Walkthrough

The pull request introduces a minor version update for the junit-platform-engine dependency in the project's dependency configuration. The change involves incrementing the version from 1.11.3 to 1.11.4 within the depends.scala file, specifically in the junit variable definition. This update represents a routine maintenance task to keep the project's dependencies current.

Changes

File Change Summary
project/depends.scala Updated junit-platform-engine dependency version from 1.11.3 to 1.11.4

Poem

🐰 A Dependency Dance

Hop, hop, version bump so light,
JUnit's engine gleams just right,
From 1.11.3 to 1.11.4,
A tiny leap through library's door,
Dependency magic takes its flight! πŸš€


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 883725d and 7ed9a9f.

πŸ“’ Files selected for processing (1)
  • project/depends.scala (1 hunks)
πŸ”‡ Additional comments (1)
project/depends.scala (1)

26-26: Verify compatibility with the new version

Let's verify if there are any breaking changes or known issues with this version update.

βœ… Verification successful

Let me gather more information about the current version and its usage.


Based on the search results, I can now generate a final response since we have sufficient information about the JUnit usage in the codebase.

Version update appears safe to proceed

The codebase shows JUnit integration primarily through test runners and specifications, with no direct engine-specific implementation dependencies. The update to junit-platform-engine 1.11.4 is being used alongside JUnitVintage, which is a standard pattern. The usage patterns found in the codebase (mainly through @RunWith annotations and specification classes) are stable APIs that are unlikely to be affected by this minor version update.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for compatibility issues and release notes for junit-platform-engine 1.11.4

# Check the GitHub releases page for JUnit Platform
gh api \
  -H "Accept: application/vnd.github+json" \
  repos/junit-team/junit5/releases | \
  jq '.[] | select(.tag_name | contains("r1.11.4")) | {name: .name, body: .body}'

# Look for any existing usage patterns that might be affected
rg -A 3 "junit-platform-engine" --type scala

Length of output: 898


Script:

#!/bin/bash
# Check the current version being used
rg -p "junit-platform-engine.*\d+\.\d+\.\d+" --type scala

# Check for any test configurations or specific engine usage
rg -p "JUnitEngine|@Test|@RunWith" --type scala -A 3

# Look for any build files that might show dependency relationships
fd "build.sbt|\.scala$" --type f --exec grep -l "junit"

Length of output: 2885

@@ -23,7 +23,7 @@ object depends {

// used in specs2-junit
val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.3"
val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.3")
val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.4")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Version mismatch between JUnit dependencies

The junit-platform-engine is being updated to version 1.11.4, while junit-vintage-engine remains at version 5.11.3. These related JUnit dependencies should maintain version alignment to ensure compatibility.

Apply this diff to align the versions:

-  val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.3"
-  val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.4")
+  val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.4"
+  val junit = libraryDependencies ++= Seq(junitVintage, "org.junit.platform" % "junit-platform-engine" % "1.11.4")

Committable suggestion skipped: line range outside the PR's diff.

@etorreborre etorreborre merged commit 5fa460c into etorreborre:main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants