-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scalafmt-core to 3.8.4 #1297
Update scalafmt-core to 3.8.4 #1297
Conversation
Executed command: scalafmt --non-interactive
WalkthroughThis pull request encompasses a series of minor formatting and documentation updates across multiple files in the Specs2 project. The changes primarily involve code style improvements, such as adjusting method signatures, reformatting comments, and updating configuration files. The modifications are predominantly cosmetic and do not alter the fundamental functionality of the codebase. The scalafmt version has been updated to 3.8.4, and various files have received formatting refinements to improve readability. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
common/shared/src/main/scala/org/specs2/text/ShowText.scala (1)
Line range hint
331-400
: Consider using Product types for better maintainability.While the current implementation with tuple types works correctly, consider using a Product type (case class) for the return values to improve maintainability and readability, especially when dealing with many parameters.
Example implementation:
case class ShowResult(values: List[String]) def show(...): ShowResult = ShowResult(List(show1(t1), show2(t2), ...))This approach would:
- Make the code more maintainable as you add more type parameters
- Provide a more semantic API
- Allow for easier addition of helper methods on the result type
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (14)
.git-blame-ignore-revs
(1 hunks).scalafmt.conf
(1 hunks)common/native/src/main/scala/scala/concurrent/ExecutionContext.scala
(2 hunks)common/shared/src/main/scala/org/specs2/control/Property.scala
(1 hunks)common/shared/src/main/scala/org/specs2/execute/Snippets.scala
(0 hunks)common/shared/src/main/scala/org/specs2/main/Diffs.scala
(1 hunks)common/shared/src/main/scala/org/specs2/text/AnsiColors.scala
(1 hunks)common/shared/src/main/scala/org/specs2/text/ShowText.scala
(3 hunks)core/shared/src/main/scala/org/specs2/specification/create/S2StringContext.scala
(1 hunks)core/shared/src/main/scala/org/specs2/specification/process/Executor.scala
(0 hunks)html/src/main/scala/org/specs2/reporter/HtmlBodyPrinter.scala
(2 hunks)matcher/shared/src/main/scala/org/specs2/matcher/Matcher.scala
(0 hunks)matcher/shared/src/main/scala/org/specs2/matcher/TraversableMatchers.scala
(1 hunks)scalacheck/src/main/scala/org/specs2/scalacheck/ScalaCheckProperty.scala
(1 hunks)
π€ Files with no reviewable changes (3)
- core/shared/src/main/scala/org/specs2/specification/process/Executor.scala
- common/shared/src/main/scala/org/specs2/execute/Snippets.scala
- matcher/shared/src/main/scala/org/specs2/matcher/Matcher.scala
β Files skipped from review due to trivial changes (9)
- html/src/main/scala/org/specs2/reporter/HtmlBodyPrinter.scala
- common/shared/src/main/scala/org/specs2/control/Property.scala
- common/shared/src/main/scala/org/specs2/main/Diffs.scala
- common/shared/src/main/scala/org/specs2/text/AnsiColors.scala
- .git-blame-ignore-revs
- common/native/src/main/scala/scala/concurrent/ExecutionContext.scala
- .scalafmt.conf
- core/shared/src/main/scala/org/specs2/specification/create/S2StringContext.scala
- scalacheck/src/main/scala/org/specs2/scalacheck/ScalaCheckProperty.scala
π Additional comments (4)
matcher/shared/src/main/scala/org/specs2/matcher/TraversableMatchers.scala (1)
613-613
: LGTM! Formatting change by scalafmt.The indentation adjustment improves code readability while maintaining the same functionality.
common/shared/src/main/scala/org/specs2/text/ShowText.scala (3)
331-340
: LGTM! Return type signature matches parameter count.The return type signature
(String, String, String, String, String, String, String, String)
correctly matches the number of parameters, maintaining type safety and consistency.
360-370
: LGTM! Return type signature matches parameter count.The return type signature
(String, String, String, String, String, String, String, String, String)
correctly matches the number of parameters, maintaining type safety and consistency.
389-400
: LGTM! Return type signature matches parameter count.The return type signature
(String, String, String, String, String, String, String, String, String, String)
correctly matches the number of parameters, maintaining type safety and consistency.
Update done manually. |
About this PR
π¦ Updates org.scalameta:scalafmt-core from
3.8.3
to3.8.4
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
Summary by CodeRabbit
Chores
Refactor
TraversableMatchers
to support more complex value checksDocumentation