fix race condition with receiving messages #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer call receiveBegin() from inside receiveDone() if no data's ready. Previously, if interruptHandler triggerred while receiveDone() was processing, receiveBegin() would wipe out the received data. This could be mitigated with sleeps between loops to decrease the odds of such a scenario, but it's far more reliable to just let the user explicitly call receiveBegin() once they have processed the latest message. This should fix issue etrombly#29
There was a problem hiding this comment.
Have you verified that this works? My transmitter node is an Arduino using LowPowerLab's RFM69 library (latest commit 855889c from March 3rd) and receiver node is an RPi. I've tried your commit and (for me at least) the Arduino transmitter node still doesn't see ACK for ~90% of packets, even though the RPi is definitely receiving them. Transmitting from the RPi to the Arduino works fine. I know it's an issue at the Pi end as I've tried the same radios attached to an Arduino at both ends and it works fine.
|
I'll have to set back up a pi to test with. Don't have anything setup right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer call receiveBegin() from inside receiveDone() if no data's
ready. Previously, if interruptHandler triggerred while receiveDone()
was processing, receiveBegin() would wipe out the received data. This
could be mitigated with sleeps between loops to decrease the odds of
such a scenario, but it's far more reliable to just let the user
explicitly call receiveBegin() once they have processed the latest
message. This should fix issue #29