-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New send variant: listenMode #41
base: master
Are you sure you want to change the base?
Conversation
Default INT pin is now 29 (not 28)
Or would it be a better practice for our project to extend the class RFM69? |
I like adding the timeout to sending, would want it to be configurable though. What is the difference with this mode? I'd want to change the name of init to something like configureListenMode. |
We are using this mode in a project with battery powered sensor nodes communicating with a gateway on a Raspberry Pi (cf. https://gitlab.com/ingoha/diy-homeautomation). |
|
the sleep timeout is hard coded to 1 second. I think it could be useful, maybe call it wakeMode, or something along those lines. If you do the code cleanup and add an example I'd be happy to merge it. |
Could you please review the changes? If the changes are ready to merge, I will remove the commits to other files than RFM69.py and stash the rest into one... |
It looks good, sorry for the huge delay on this. I started a new job and ended up forgetting about it. |
No problem ;-) |
Yes, thank you |
As I have just read; you can simply use the option "squash and merge" when merging the PR... |
This new sending method was developed in a study project some time ago; are you interested to merge it?
If so, I can provide you with some background information...