Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New send variant: listenMode #41

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

ingoha
Copy link

@ingoha ingoha commented Dec 25, 2020

This new sending method was developed in a study project some time ago; are you interested to merge it?
If so, I can provide you with some background information...

@ingoha
Copy link
Author

ingoha commented Dec 25, 2020

Or would it be a better practice for our project to extend the class RFM69?

@etrombly
Copy link
Owner

I like adding the timeout to sending, would want it to be configurable though. What is the difference with this mode? I'd want to change the name of init to something like configureListenMode.

@ingoha
Copy link
Author

ingoha commented Dec 27, 2020

We are using this mode in a project with battery powered sensor nodes communicating with a gateway on a Raspberry Pi (cf. https://gitlab.com/ingoha/diy-homeautomation).
To save power, the nodes are in a sleep mode and can be woke up by sending a "burst" to their RFM chip which then triggers an interrupt on the µC.
So this is what the new mode does: it wakes up a node and e.g. transmits a command to control an actor.

@ingoha
Copy link
Author

ingoha commented Dec 27, 2020

  • What do you mean with configurable?
  • Yes, the name init is not well chosen ;-) If you consider merging, i could do some tidy up of the code...

@etrombly
Copy link
Owner

the sleep timeout is hard coded to 1 second.
if slept > 1.0:

I think it could be useful, maybe call it wakeMode, or something along those lines. If you do the code cleanup and add an example I'd be happy to merge it.

@ingoha
Copy link
Author

ingoha commented Dec 28, 2020

Could you please review the changes? If the changes are ready to merge, I will remove the commits to other files than RFM69.py and stash the rest into one...

@etrombly
Copy link
Owner

etrombly commented Aug 19, 2021

It looks good, sorry for the huge delay on this. I started a new job and ended up forgetting about it.

@ingoha
Copy link
Author

ingoha commented Aug 20, 2021

No problem ;-)
Should I stash the commits?

@etrombly
Copy link
Owner

Yes, thank you

@ingoha
Copy link
Author

ingoha commented Aug 27, 2021

As I have just read; you can simply use the option "squash and merge" when merging the PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants