-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: add github actions #30
Conversation
foundry.toml
Outdated
ignore = [ | ||
"src/EVault/EVault.sol", | ||
"src/EVault/shared/Storage.sol", | ||
"src/EVault/shared/types/MarketStorage.sol", | ||
"src/EVault/shared/types/MarketCache.sol" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this.
Is there any specific reason those were excluded from formatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dglowinski any reason for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, more readability ;) like storage slots separated by blank spaces
Evault especially we want to have one line per function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why put remappings in a file? We don't do it in EVC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think from readability side, it is easier to read when formatted than having a really long line in EVault XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only if you're after reading the whole line, which is probably not why you go to that file. It's mostly boilerplate, what's interesting is the nice list of functions you can quickly scan. There's not much interesting happening in the lines to the right of the function name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will close this for now and open new one in a bit.
96aca38
to
c4e7911
Compare
This PR:
forge fmt
remappings.txt
file