Restore encapsulation of distributions layout, broken by gas optimisa… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/BaseRewardStreams.sol
Outdated
| /// @param distributionStorage Pre-computed distribution storage pointer. | ||
| /// @param epoch The epoch to get the reward token amount for. | ||
| /// @return The reward token amount. | ||
| function rewardAmount( |
There was a problem hiding this comment.
nit: please move this function to the bottom where other internal functions are defined
There was a problem hiding this comment.
OK, but I'll wait until the readability PR lands, because I foresee merge conflicts :)
There was a problem hiding this comment.
the readability PR is merged
There was a problem hiding this comment.
I rebased, and moved the function
hoytech
force-pushed
the
restore-encapsulation
branch
from
1970a2d to
67b6001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions