Internal review #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.6.0
…ble`, move `deltaAccountZero` to last
feat: optimize storage pointers
Add license file
totomanov
reviewed
Apr 25, 2024
| forge test -vvv --gas-report --ast | ||
| id: test | ||
|
|
||
| coverage: |
There was a problem hiding this comment.
I was wondering about this in the other repo as well, why do we run coverage in the CI?
There was a problem hiding this comment.
Haythem set it up this way for the EVK and to be honest I simply copy-pasted the file here. I don't think it's an issue though
totomanov
reviewed
Apr 25, 2024
Remove redundant `.solhint.json`
hoytech
commented
Apr 30, 2024
|
|
||
| accountStorage.balance = currentAccountBalance - amount; | ||
|
|
||
| IERC20(rewarded).safeTransfer(recipient, amount); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hoytech
commented
Apr 30, 2024
Readability improvements
hoytech
commented
Apr 30, 2024
hoytech
commented
Apr 30, 2024
Restore encapsulation of distributions layout, broken by gas optimisa…
hoytech
commented
Apr 30, 2024
leemount96
reviewed
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.