Modernize packaging and plugin discovery #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 5 +1
Lines 81 103 +22
=========================================
+ Hits 81 103 +22 ☔ View full report in Codecov by Sentry. |
use poetry to install package for quality checks purpose Use dedicated poetry action for quality checks job Restore mypy configuration Add -p switch to mypy invocation Try running mypy only in src directory explicitly set mypy path in pyproject.toml
Fix Python version
dexter2206
force-pushed
the
kj/packaging-changes
branch
from
0aa04fa to
a252582
Compare
lpawela
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several details about our setup that modernize how we handle packaging and plugin discovery. The changes are:
importlib.metadatafor plugin discovery.pluggyimportlib.metadatais no longer provisional as of Python 3.10 (and its backportimportlib_metadatais stable)importlib.resourcesinstead ofpkg_resources, which is now deprecated