-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower Joi dependency #34
base: 3.x
Are you sure you want to change the base?
Conversation
* BREAKING CHANGE: update to support @hapi/joi v16 * chore: pin to minor versions in deps * fix: bump node types * chore: update licence
exporessJoiValidator => expressJoiValidator
…ortiss#26) * fix: address changes in joi v16 types * chore: bump verison to 4.0.2 * docs: changelog for 4.0.2 * fix: should still extend * fix: remove joi-extract-type temporarily
* fix: address new qs typings in express types
* fix: address new qs typings in express types * [BREAKING CHANGE]: Optional global joi options. Co-authored-by: Evan Shortiss <[email protected]>
So it looks like now it doesn't compile with a newer Joi because of that same type no longer being generic? |
@danielbrauer correct, but the reason for this 3.x release is to support joi-extract-type which requires Joi v15. So all Joi deps need to be 15.x variants |
Of course. Reducing those dependencies allows tests to pass here. |
Set Joi peer dependency to 15, and fixed generic type parameter as per #30 (comment)
Also merged
master