Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower Joi dependency #34

Open
wants to merge 16 commits into
base: 3.x
Choose a base branch
from
Open

Conversation

danielbrauer
Copy link

@danielbrauer danielbrauer commented Aug 4, 2020

Set Joi peer dependency to 15, and fixed generic type parameter as per #30 (comment)

Also merged master

evanshortiss and others added 15 commits August 30, 2019 20:42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* BREAKING CHANGE: update to support @hapi/joi v16

* chore: pin to minor versions in deps

* fix: bump node types

* chore: update licence
exporessJoiValidator => expressJoiValidator
…ortiss#26)

* fix: address changes in joi v16 types

* chore: bump verison to 4.0.2

* docs: changelog for 4.0.2

* fix: should still extend

* fix: remove joi-extract-type temporarily
* fix: address new qs typings in express types
* fix: address new qs typings in express types

* [BREAKING CHANGE]: Optional global joi options.

Co-authored-by: Evan Shortiss <[email protected]>
@danielbrauer danielbrauer changed the title Added generic type parameter for ExpressJoiError Lower Joi dependency Aug 4, 2020
@danielbrauer
Copy link
Author

So it looks like now it doesn't compile with a newer Joi because of that same type no longer being generic?

@evanshortiss
Copy link
Owner

@danielbrauer correct, but the reason for this 3.x release is to support joi-extract-type which requires Joi v15. So all Joi deps need to be 15.x variants

@danielbrauer
Copy link
Author

@danielbrauer correct, but the reason for this 3.x release is to support joi-extract-type which requires Joi v15.

Of course. Reducing those dependencies allows tests to pass here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants