This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
CLI is complete, Tests are working. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an ugly name clash between the assembly name for the class library and the class I'm developing, which caused more typing, and was just ugly. Therefore, I've refactored it to something more pleasing.
Next Step: Unit Tests!
In the next couple of commits, when I implement actual unit tests, it'll be useful to have a dependency-injected data source for mocking.
| [Option(null, "connection_string", DefaultValue="Data Source=localhost; Initial Catalog=ebs_DATADUMP; Integrated Security=SSPI;", HelpText = "The database connection string to use.")] | ||
| public string connectionString { get; set; } | ||
|
|
||
| [Option("t", "table", DefaultValue="*", HelpText="The database table to extract. Defaults to '*'.")] |
There was a problem hiding this comment.
The default being a wildcard implies that (a) wildcards can be used and (b) multiple tables can be extracted at the same time. If this is the case, table(s) would probably be more appropriate, and a mention of what wildcards are allowed.
Note: I decided not to split the per-row logic into its own method because I need to fire the progressMade events, and that's awkward to split across the function boundary.
|
PTAL. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUI is a stub -- pay no attention to it :)