Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-9149 Create manifest in periodic build job #8677

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ZackarySantana
Copy link
Contributor

@ZackarySantana ZackarySantana commented Jan 30, 2025

DEVPROD-9149

Description

A user was reporting an old module revision being used rather than the latest. This is because we don't insert a manifest during our periodic build job and the base commit's manifest is used instead. This inserts a manifest for the periodic build job.

Testing

I simulated the situation with the commit queue repository and github merge queue repository (which I'll reference as CQ and GM respectively).

  1. For the CQ repo, I added GM as a module (via a commit).
  2. I added a periodic build in CQ.
  3. I did a fresh commit in GM which is propagated in a log line in a CQ task (which will is now newer than the latest CQ commit).
  4. It ran this version which has the older log line here.
  5. I deployed this PR and it ran this version which has the new log line here. You can see the difference in log lines and the difference in the version manifest on the version page.

This is for the version without the update that does not create a manifest and uses the base commit (step 4):
Screenshot 2025-01-30 at 11 06 10 AM

This is for the version with the update that does create a manifest (step 5):
Screenshot 2025-01-30 at 1 11 03 PM

Documentation

TBA

@ZackarySantana ZackarySantana self-assigned this Jan 30, 2025
@ZackarySantana ZackarySantana marked this pull request as ready for review January 30, 2025 18:32
@ZackarySantana ZackarySantana changed the title DEVPROD-9149 Create manifest in periodic build job [draft] DEVPROD-9149 Create manifest in periodic build job Jan 30, 2025
@ZackarySantana ZackarySantana requested a review from a team January 30, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant