DEVPROD-14723 Mark host as needs new agent monitor on unquarantine #8689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-14723
Description
It's possible for there to be a race between the agent monitor deploy job and the host monitoring job.
When unquarantining a host back to running, if the monitoring job runs before the agent monitor deploy job, the host will immediately get marked as quarantined again if there is a long interval in its
LastCommunicatedTime. During unquarantining, this line causes the host to skip immediate reprovisioning and instead wait for the agent monitor deploy cron job to pick it up later, which opens up the possibility of a potential race.Changed the unquarantining logic to immediately set
NeedsNewAgentMonitorKey: trueby copying the same query used by the agent monitor deploy job.Testing
Unit test changes (this block) fails without the change.