Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-13567: improve retry and traceability for GitHub app token creation errors #8693

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Kimchelly
Copy link
Contributor

@Kimchelly Kimchelly commented Feb 6, 2025

DEVPROD-13567

Description

This is some improvements in preparation to fix the issue where github.generate_token will time out requesting a token from Evergreen. This will help to verify that the actual fix for DEVPROD-13567 works and overall improve our ability to monitor for issues when creating tokens.

I'm going to post a follow-up PR after this to address the ticket's issue.

  • Rework GitHub app client to support a retry function. (This functionally should behave the same, just written in a more configurable/observable way.)
  • Add OTel spans for better tracing of success/error when creating a token.
  • Add Splunk logging for non-retryable errors from the GitHub app client.

Testing

Tested in staging that the spans went to Honeycomb and Splunk errors worked as expected with the retry function. Also verified that modifying the HTTP client's transport didn't cause token creation to fail.

@Kimchelly Kimchelly requested a review from a team February 6, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant