Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd alternative to make subschema ordering consistent #523

Closed
wants to merge 3 commits into from

Conversation

erosb
Copy link
Contributor

@erosb erosb commented Feb 5, 2025

Sorts subschemas using a comparator that

  • takes combined schemas first
  • sorts the rest of them by insertion order (by remembering the order in the before-sorting collection)

This is a 3rd alternative to #522 and #519

Hello @rayokota which one do you prefer more?

@rayokota
Copy link
Contributor

rayokota commented Feb 5, 2025

@erosb , thanks for putting extra thought into this issue!

I think I prefer #522. It restores the original insertion order for getSubschemas(), and allows the internal iteration order to differ according to the needs of validation and equals/hashCode checks. What do you think?

@erosb erosb closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants