-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammar based moves parsing #80
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everyonesdesign
force-pushed
the
grammar-based-moves-parsing
branch
from
February 2, 2025 16:19
4a44c6c
to
9822e96
Compare
everyonesdesign
force-pushed
the
grammar-based-moves-parsing
branch
from
February 2, 2025 19:30
599065c
to
63115f6
Compare
Closing in favour of #82 Implementation based on Nearley seems to be difficult to maintain and very slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better, more flexible way to parse moves defined by grammar instead of regular expressions
Using Nearley to generate and parse the grammar
TypeScript definitions are manually created
Potentially can unblock things like #74
Concerns
Performance and the bundle size.
Bundle size ✅
Bundle size (master): 116K
Bundle size (feature): 126K
Performance ❌
It seems that the performance with this parsing decreases significantly: