Implement all applicable GeoInterface methods for DataFrames #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But not traits.
This implements
GI.crs
andGI.geometrycolumns
for DataFrames and DataFrameRows, as well asGI.getfeature
for DataFrame andGI.geometry
andGI.properties
for DataFrameRows.It also adds the namespace proposition from GeoInterface, so there are now four metadata entries in any GeoDataFrame by default. These are exact copies of the originals, and the original
crs
andgeometrycolumns
entries are retained for backwards compatibility.The new metadata entries are
GEOINTERFACE:crs
andGEOINTERFACE:geometrycolumns
, which are namespaced metadata according to the Arrow spec.This does not support other tables at the moment - that's probably a decision best made in GeoInterface, since it would need to take on Tables.jl and DataAPI.jl as direct dependencies (to avoid bringing in Requires on Julia < 1.9).